solution #473
Open
solution #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LiudmylaKulinchenko
suggested changes
Nov 18, 2023
accounts/urls.py
Outdated
There was a problem hiding this comment.
No need to create an app here, you have urls from django.contrib.auth.urls (taxi_service/urls.py 25th line)
LiudmylaKulinchenko
suggested changes
Nov 20, 2023
| @@ -22,4 +22,5 @@ | |||
| urlpatterns = [ | |||
| path("admin/", admin.site.urls), | |||
| path("", include("taxi.urls", namespace="taxi")), | |||
| path("accounts/", include("django.contrib.auth.urls")) | |||
There was a problem hiding this comment.
it was about whole accounts app
you have login/logout urls from django.contrib.auth.urls, haven't you?
LiudmylaKulinchenko
suggested changes
Nov 21, 2023
taxi_service/urls.py
Outdated
| @@ -22,4 +22,5 @@ | |||
| urlpatterns = [ | |||
| path("admin/", admin.site.urls), | |||
| path("", include("taxi.urls", namespace="taxi")), | |||
| path("", include("django.contrib.auth.urls")) | |||
There was a problem hiding this comment.
This line includes Django's built-in authentication URLs (like login, logout, password change, etc.)
You can also have path("accounts/", include("django.contrib.auth.urls")) here
But again, why do you need accounts app here, if you have all urls in this file? You can remove accounts app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.